third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2730573003: Moved FrameHost::m_visualViewport to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)

Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/TextAutosizer.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index b7ed656d74a80e1f7942872ad72f305004e7f4b1..8dd0dbed3788300c03c57402df6fc5888679721f 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -1590,13 +1590,10 @@ void CompositedLayerMapping::updateInternalHierarchy() {

// TODO(pdr): Ensure painting uses the correct GraphicsLayer when root layer

// scrolls is enabled. crbug.com/638719

if (m_isMainFrameLayoutViewLayer &&

- !RuntimeEnabledFeatures::slimmingPaintV2Enabled())

- bottomLayer = layoutObject()

- .frame()

- ->page()

- ->frameHost()

- .visualViewport()

- .containerLayer();

+ !RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

+ bottomLayer =

+ layoutObject().frame()->page()->visualViewport().containerLayer();

+ }

updateBottomLayer(m_overflowControlsAncestorClippingLayer.get());

updateBottomLayer(m_overflowControlsHostLayer.get());

if (m_layerForHorizontalScrollbar)