Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2727633004: Change UsbDeviceFilter to use const references instead of (Closed)

Created:
3 years, 9 months ago by Carlson
Modified:
3 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), davemoore+watch_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change UsbDeviceFilter to use const references instead of scoped_reftpr where the former will work. Also fix some lint issues in the edited files to make lint clean. (missing includes, missing 'explicit' keywords) BUG= Review-Url: https://codereview.chromium.org/2727633004 Cr-Commit-Position: refs/heads/master@{#460138} Committed: https://chromium.googlesource.com/chromium/src/+/86ade12dc989297c292d985e7bb9519fa4e2fce2

Patch Set 1 #

Patch Set 2 : Fix missed android callsite #

Patch Set 3 : Sync and rebase #

Patch Set 4 : Add missing file delta to cl #

Patch Set 5 : Fix 2 more callsites revealed by the last callsite... #

Patch Set 6 : Fix callsite missed earlier due to not building for CrOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -40 lines) Patch
M chrome/browser/chromeos/printer_detector/cups_printer_detector.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/printer_detector/legacy_printer_detector.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/printing/usb_printer_util.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/printing/usb_printer_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/usb_chooser_dialog_android.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M device/usb/mojo/device_manager_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/usb/usb_device_filter.h View 2 chunks +6 lines, -3 lines 0 comments Download
M device/usb/usb_device_filter.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M device/usb/usb_device_filter_unittest.cc View 4 chunks +19 lines, -18 lines 0 comments Download
M extensions/browser/api/device_permissions_prompt.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/printer_provider/usb_printer_manifest_data.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 35 (28 generated)
Carlson
Apparently I never actually sent mail for this change, oops.
3 years, 9 months ago (2017-03-24 17:31:38 UTC) #12
Reilly Grant (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-24 20:56:43 UTC) #13
Carlson
Adding jam@ and rockot@ for callsite OWNERS signoffs.
3 years, 8 months ago (2017-03-27 17:54:46 UTC) #15
Ken Rockot(use gerrit already)
rs lgtm
3 years, 8 months ago (2017-03-27 17:56:41 UTC) #16
jam
On 2017/03/27 17:54:46, Carlson wrote: > Adding jam@ and rockot@ for callsite OWNERS signoffs. I ...
3 years, 8 months ago (2017-03-27 20:02:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727633004/100001
3 years, 8 months ago (2017-03-28 16:03:47 UTC) #32
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:00:31 UTC) #35
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/86ade12dc989297c292d985e7bb9...

Powered by Google App Engine
This is Rietveld 408576698