Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: device/usb/mojo/device_manager_impl.cc

Issue 2727633004: Change UsbDeviceFilter to use const references instead of (Closed)
Patch Set: Fix callsite missed earlier due to not building for CrOS Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/usb/usb_chooser_controller.cc ('k') | device/usb/usb_device_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/mojo/device_manager_impl.cc
diff --git a/device/usb/mojo/device_manager_impl.cc b/device/usb/mojo/device_manager_impl.cc
index d7657deb6db7293da8bc13e4fb61f261b797fe0f..413a1fae25a9ca2ea0c0476ad5364d42238ad209 100644
--- a/device/usb/mojo/device_manager_impl.cc
+++ b/device/usb/mojo/device_manager_impl.cc
@@ -7,7 +7,9 @@
#include <stddef.h>
#include <memory>
+#include <string>
#include <utility>
+#include <vector>
#include "base/bind.h"
#include "base/memory/ptr_util.h"
@@ -92,7 +94,7 @@ void DeviceManagerImpl::OnGetDevices(
std::vector<DeviceInfoPtr> device_infos;
for (const auto& device : devices) {
- if (UsbDeviceFilter::MatchesAny(device, filters)) {
+ if (UsbDeviceFilter::MatchesAny(*device, filters)) {
if (permission_provider_ &&
permission_provider_->HasDevicePermission(device)) {
device_infos.push_back(DeviceInfo::From(*device));
« no previous file with comments | « chrome/browser/usb/usb_chooser_controller.cc ('k') | device/usb/usb_device_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698