Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: chrome/browser/chromeos/printer_detector/cups_printer_detector.cc

Issue 2727633004: Change UsbDeviceFilter to use const references instead of (Closed)
Patch Set: Fix callsite missed earlier due to not building for CrOS Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/printer_detector/legacy_printer_detector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/printer_detector/cups_printer_detector.cc
diff --git a/chrome/browser/chromeos/printer_detector/cups_printer_detector.cc b/chrome/browser/chromeos/printer_detector/cups_printer_detector.cc
index 3719c474e7dbffc25c9f6fb68d920cd25842f675..05369a7ae9c694b9f9b8120248c46638bfd17a00 100644
--- a/chrome/browser/chromeos/printer_detector/cups_printer_detector.cc
+++ b/chrome/browser/chromeos/printer_detector/cups_printer_detector.cc
@@ -102,7 +102,7 @@ class CupsPrinterDetectorImpl : public PrinterDetector,
// UsbService::observer override.
void OnDeviceRemoved(scoped_refptr<device::UsbDevice> device) override {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- if (!UsbDeviceIsPrinter(device)) {
+ if (!UsbDeviceIsPrinter(*device)) {
return;
}
known_printers_.erase(device->guid());
@@ -132,7 +132,7 @@ class CupsPrinterDetectorImpl : public PrinterDetector,
bool hotplugged) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- if (!UsbDeviceIsPrinter(device) ||
+ if (!UsbDeviceIsPrinter(*device) ||
base::ContainsKey(known_printers_, device->guid())) {
return;
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/printer_detector/legacy_printer_detector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698