Change UsbDeviceFilter to use const references instead of

device/usb/usb_device_filter_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <string>
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "device/usb/mock_usb_device.h"
 #include "device/usb/usb_descriptors.h"
 #include "device/usb/usb_device_filter.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace device {
@@ skipping 11 matching lines @@
     android_phone_ = new MockUsbDevice(0x18d1, 0x4ee2, "Google Inc.", "Nexus 5",
                                        "ABC123", {config});
   }
 
  protected:
   scoped_refptr<MockUsbDevice> android_phone_;
 };
 
 TEST_F(UsbFilterTest, MatchAny) {
   UsbDeviceFilter filter;
-  ASSERT_TRUE(filter.Matches(android_phone_));
+  ASSERT_TRUE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchVendorId) {
   UsbDeviceFilter filter;
   filter.vendor_id = 0x18d1;
-  ASSERT_TRUE(filter.Matches(android_phone_));
+  ASSERT_TRUE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchVendorIdNegative) {
   UsbDeviceFilter filter;
   filter.vendor_id = 0x1d6b;
-  ASSERT_FALSE(filter.Matches(android_phone_));
+  ASSERT_FALSE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchProductId) {
   UsbDeviceFilter filter;
   filter.vendor_id = 0x18d1;
   filter.product_id = 0x4ee2;
-  ASSERT_TRUE(filter.Matches(android_phone_));
+  ASSERT_TRUE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchProductIdNegative) {
   UsbDeviceFilter filter;
   filter.vendor_id = 0x18d1;
   filter.product_id = 0x4ee1;
-  ASSERT_FALSE(filter.Matches(android_phone_));
+  ASSERT_FALSE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchInterfaceClass) {
   UsbDeviceFilter filter;
   filter.interface_class = 0xff;
-  ASSERT_TRUE(filter.Matches(android_phone_));
+  ASSERT_TRUE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchInterfaceClassNegative) {
   UsbDeviceFilter filter;
   filter.interface_class = 0xe0;
-  ASSERT_FALSE(filter.Matches(android_phone_));
+  ASSERT_FALSE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchInterfaceSubclass) {
   UsbDeviceFilter filter;
   filter.interface_class = 0xff;
   filter.interface_subclass = 0x42;
-  ASSERT_TRUE(filter.Matches(android_phone_));
+  ASSERT_TRUE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchInterfaceSubclassNegative) {
   UsbDeviceFilter filter;
   filter.interface_class = 0xff;
   filter.interface_subclass = 0x01;
-  ASSERT_FALSE(filter.Matches(android_phone_));
+  ASSERT_FALSE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchInterfaceProtocol) {
   UsbDeviceFilter filter;
   filter.interface_class = 0xff;
   filter.interface_subclass = 0x42;
   filter.interface_protocol = 0x01;
-  ASSERT_TRUE(filter.Matches(android_phone_));
+  ASSERT_TRUE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchInterfaceProtocolNegative) {
   UsbDeviceFilter filter;
   filter.interface_class = 0xff;
   filter.interface_subclass = 0x42;
   filter.interface_protocol = 0x02;
-  ASSERT_FALSE(filter.Matches(android_phone_));
+  ASSERT_FALSE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchSerialNumber) {
   UsbDeviceFilter filter;
   filter.serial_number = std::string("ABC123");
-  EXPECT_TRUE(filter.Matches(android_phone_));
+  EXPECT_TRUE(filter.Matches(*android_phone_));
   filter.vendor_id = 0x18d1;
-  EXPECT_TRUE(filter.Matches(android_phone_));
+  EXPECT_TRUE(filter.Matches(*android_phone_));
   filter.vendor_id = 0x18d2;
-  EXPECT_FALSE(filter.Matches(android_phone_));
+  EXPECT_FALSE(filter.Matches(*android_phone_));
   filter.vendor_id = 0x18d1;
   filter.serial_number = std::string("DIFFERENT");
-  EXPECT_FALSE(filter.Matches(android_phone_));
+  EXPECT_FALSE(filter.Matches(*android_phone_));
 }
 
 TEST_F(UsbFilterTest, MatchAnyEmptyList) {
   std::vector<UsbDeviceFilter> filters;
-  ASSERT_TRUE(UsbDeviceFilter::MatchesAny(android_phone_, filters));
+  ASSERT_TRUE(UsbDeviceFilter::MatchesAny(*android_phone_, filters));
 }
 
 TEST_F(UsbFilterTest, MatchesAnyVendorId) {
   std::vector<UsbDeviceFilter> filters(1);
   filters.back().vendor_id = 0x18d1;
-  ASSERT_TRUE(UsbDeviceFilter::MatchesAny(android_phone_, filters));
+  ASSERT_TRUE(UsbDeviceFilter::MatchesAny(*android_phone_, filters));
 }
 
 TEST_F(UsbFilterTest, MatchesAnyVendorIdNegative) {
   std::vector<UsbDeviceFilter> filters(1);
   filters.back().vendor_id = 0x1d6b;
-  ASSERT_FALSE(UsbDeviceFilter::MatchesAny(android_phone_, filters));
+  ASSERT_FALSE(UsbDeviceFilter::MatchesAny(*android_phone_, filters));
 }
 
 }  // namespace
 
 }  // namespace device