Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: extensions/common/api/printer_provider/usb_printer_manifest_data.cc

Issue 2727633004: Change UsbDeviceFilter to use const references instead of (Closed)
Patch Set: Fix callsite missed earlier due to not building for CrOS Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/usb/usb_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/printer_provider/usb_printer_manifest_data.cc
diff --git a/extensions/common/api/printer_provider/usb_printer_manifest_data.cc b/extensions/common/api/printer_provider/usb_printer_manifest_data.cc
index c34a349e7862e875876074ffe93fd936f8b72d34..fc5c46606f43280b4b405aec5d5637258d64364d 100644
--- a/extensions/common/api/printer_provider/usb_printer_manifest_data.cc
+++ b/extensions/common/api/printer_provider/usb_printer_manifest_data.cc
@@ -4,6 +4,8 @@
#include "extensions/common/api/printer_provider/usb_printer_manifest_data.h"
+#include <memory>
+
#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "device/usb/usb_device.h"
@@ -69,7 +71,7 @@ std::unique_ptr<UsbPrinterManifestData> UsbPrinterManifestData::FromValue(
bool UsbPrinterManifestData::SupportsDevice(
const scoped_refptr<device::UsbDevice>& device) const {
for (const auto& filter : filters_) {
- if (filter.Matches(device))
+ if (filter.Matches(*device))
return true;
}
« no previous file with comments | « extensions/browser/api/usb/usb_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698