chrome/browser/chromeos/printing/usb_printer_util.cc - Issue 2727633004: Change UsbDeviceFilter to use const references instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/printing/usb_printer_util.cc

Issue 2727633004: Change UsbDeviceFilter to use const references instead of (Closed)

Patch Set: Fix callsite missed earlier due to not building for CrOS Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/printing/usb_printer_util.cc

diff --git a/chrome/browser/chromeos/printing/usb_printer_util.cc b/chrome/browser/chromeos/printing/usb_printer_util.cc

index 025edc1e12e1f7907b969a5170e60cda8b16b5c7..765fdd0bf2f11f2237148182e1179ed34901c2e7 100644

--- a/chrome/browser/chromeos/printing/usb_printer_util.cc

+++ b/chrome/browser/chromeos/printing/usb_printer_util.cc

@@ -50,7 +50,7 @@ std::string CupsURIEscape(const std::string& uri_in) {

} // namespace

-bool UsbDeviceIsPrinter(scoped_refptr<device::UsbDevice> usb_device) {

+bool UsbDeviceIsPrinter(const device::UsbDevice& usb_device) {

device::UsbDeviceFilter printer_filter;

printer_filter.interface_class = kPrinterInterfaceClass;

return printer_filter.Matches(usb_device);