chrome/browser/ui/android/usb_chooser_dialog_android.cc - Issue 2727633004: Change UsbDeviceFilter to use const references instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/usb_chooser_dialog_android.cc

Issue 2727633004: Change UsbDeviceFilter to use const references instead of (Closed)

Patch Set: Fix callsite missed earlier due to not building for CrOS Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/usb_chooser_dialog_android.cc

diff --git a/chrome/browser/ui/android/usb_chooser_dialog_android.cc b/chrome/browser/ui/android/usb_chooser_dialog_android.cc

index c74ce3a210bd8649e08e3a31444f1ea474b97934..b462ca357ae81bf526baf015d6479fcc8d503d71 100644

--- a/chrome/browser/ui/android/usb_chooser_dialog_android.cc

+++ b/chrome/browser/ui/android/usb_chooser_dialog_android.cc

@@ -225,7 +225,7 @@ void UsbChooserDialogAndroid::OpenUrl(const std::string& url) {

bool UsbChooserDialogAndroid::DisplayDevice(

scoped_refptr<UsbDevice> device) const {

- if (!device::UsbDeviceFilter::MatchesAny(device, filters_))

+ if (!device::UsbDeviceFilter::MatchesAny(*device, filters_))

return false;

// On Android it is not possible to read the WebUSB descriptors until Chrome