Change UsbDeviceFilter to use const references instead of

extensions/browser/api/device_permissions_prompt.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/device_permissions_prompt.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/i18n/message_formatter.h"
@@ skipping 29 matching lines @@
 
 namespace {
 
 void NoopHidCallback(const std::vector<scoped_refptr<device::HidDeviceInfo>>&) {
 }
 
 void NoopUsbCallback(const std::vector<scoped_refptr<device::UsbDevice>>&) {}
 
 class UsbDeviceInfo : public DevicePermissionsPrompt::Prompt::DeviceInfo {
  public:
-  UsbDeviceInfo(scoped_refptr<UsbDevice> device) : device_(device) {
+  explicit UsbDeviceInfo(scoped_refptr<UsbDevice> device) : device_(device) {
     name_ = DevicePermissionsManager::GetPermissionMessage(
         device->vendor_id(), device->product_id(),
         device->manufacturer_string(), device->product_string(),
         base::string16(),  // Serial number is displayed separately.
         true);
     serial_number_ = device->serial_number();
   }
 
   ~UsbDeviceInfo() override {}
 
@@ skipping 52 matching lines @@
         }
       }
     }
     DCHECK(multiple() || devices.size() <= 1);
     callback_.Run(devices);
     callback_.Reset();
   }
 
   // device::UsbService::Observer implementation:
   void OnDeviceAdded(scoped_refptr<UsbDevice> device) override {
-    if (!UsbDeviceFilter::MatchesAny(device, filters_))
+    if (!UsbDeviceFilter::MatchesAny(*device, filters_))
       return;
 
     std::unique_ptr<DeviceInfo> device_info(new UsbDeviceInfo(device));
     device->CheckUsbAccess(
         base::Bind(&UsbDevicePermissionsPrompt::AddCheckedDevice, this,
                    base::Passed(&device_info)));
   }
 
   void OnDeviceRemoved(scoped_refptr<UsbDevice> device) override {
     for (auto it = devices_.begin(); it != devices_.end(); ++it) {
@@ skipping 17 matching lines @@
     }
   }
 
   std::vector<UsbDeviceFilter> filters_;
   DevicePermissionsPrompt::UsbDevicesCallback callback_;
   ScopedObserver<UsbService, UsbService::Observer> service_observer_;
 };
 
 class HidDeviceInfo : public DevicePermissionsPrompt::Prompt::DeviceInfo {
  public:
-  HidDeviceInfo(scoped_refptr<device::HidDeviceInfo> device) : device_(device) {
+  explicit HidDeviceInfo(scoped_refptr<device::HidDeviceInfo> device)
+      : device_(device) {
     name_ = DevicePermissionsManager::GetPermissionMessage(
         device->vendor_id(), device->product_id(),
         base::string16(),  // HID devices include manufacturer in product name.
         base::UTF8ToUTF16(device->product_name()),
         base::string16(),  // Serial number is displayed separately.
         false);
     serial_number_ = base::UTF8ToUTF16(device->serial_number());
   }
 
   ~HidDeviceInfo() override {}
@@ skipping 207 matching lines @@
 // static
 scoped_refptr<DevicePermissionsPrompt::Prompt>
 DevicePermissionsPrompt::CreateUsbPromptForTest(const Extension* extension,
                                                 bool multiple) {
   return make_scoped_refptr(new UsbDevicePermissionsPrompt(
       extension, nullptr, multiple, std::vector<UsbDeviceFilter>(),
       base::Bind(&NoopUsbCallback)));
 }
 
 }  // namespace extensions