Remove auto raw pointer deduction from non-linux specific code.

Remove auto raw pointer deduction from non-linux specific code.

This patch removes the rest of the auto raw pointer deduction as
detected the a clang plugin. This should be enough to enable the check
for all platforms.

R=danakj@chromium.org
TBR=cschuet@chromium.org
BUG=554600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2721553004
Cr-Commit-Position: refs/heads/master@{#454029}
Committed: https://chromium.googlesource.com/chromium/src/+/843b41a25f71a9980dbfe2f5a70407efd0ef2ea2

[vmpstr, 2017-02-27 21:08:08]

Description was changed from

==========
Remove auto raw pointer deduction from non-linux specific code.

This patch removes the rest of the auto raw pointer deduction as
detected the a clang plugin. This should be enough to enable the check
for all platforms.

R=danakj@chromium.org
BUG=554600
==========

to

==========
Remove auto raw pointer deduction from non-linux specific code.

This patch removes the rest of the auto raw pointer deduction as
detected the a clang plugin. This should be enough to enable the check
for all platforms.

R=danakj@chromium.org
BUG=554600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[vmpstr, 2017-02-27 21:08:21]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[vmpstr, 2017-02-27 21:08:50]

Please take a look.

[commit-bot: I haz the power, 2017-02-27 21:08:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 23:20:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 23:20:23]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-02-28 06:56:39]

chrome/browser/password_manager/password_store_mac.cc LGTM

[danakj, 2017-02-28 15:33:30]

Can you go thru all the cases in for() loops and try make them const when
possible?

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/offl...
File
chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
(right):

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc:216:
for (auto* item : items) {
const auto*?

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:836: for (auto* rect : elements)
{
const auto*?

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:891: for (auto* element :
elements) {
const auto*?

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc (right):

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc:365: for (auto*
user : users_) {
const?

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc:392: for (auto*
user : users) {
const?

[vmpstr, 2017-02-28 21:47:35]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[vmpstr, 2017-02-28 21:48:27]

I've updated to const auto* where I think it was OK. However, some places it's
not really trivial to tell where we can have a const object and where we can't.
If trybots fail, I'll fix up offending cases.

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/offl...
File
chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
(right):

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc:216:
for (auto* item : items) {
On 2017/02/28 15:33:29, danakj_OOO wrote:
> const auto*?

Done.

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:836: for (auto* rect : elements)
{
On 2017/02/28 15:33:30, danakj_OOO wrote:
> const auto*?

Done.

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:891: for (auto* element :
elements) {
On 2017/02/28 15:33:29, danakj_OOO wrote:
> const auto*?

Done.

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc (right):

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc:365: for (auto*
user : users_) {
On 2017/02/28 15:33:30, danakj_OOO wrote:
> const?

Can't here, assigning it to primary_user_ which is a pointer to non-const.

https://codereview.chromium.org/2721553004/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc:392: for (auto*
user : users) {
On 2017/02/28 15:33:30, danakj_OOO wrote:
> const?

Done.

[commit-bot: I haz the power, 2017-02-28 21:48:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-02-28 21:58:23]

danakj@chromium.org changed reviewers:
+ brettw@chromium.org

[danakj, 2017-02-28 21:58:24]

LGTM. +brettw for top level OWNERS. As it's mechanical, you can TBR him I think.

[commit-bot: I haz the power, 2017-02-28 21:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 21:59:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2017-02-28 22:00:21]

rs lgtm

[vmpstr, 2017-02-28 22:10:09]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-02-28 22:10:09]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
danakj@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2721553004/#ps60001
(title: "undoconst")

[commit-bot: I haz the power, 2017-02-28 22:10:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-02-28 22:11:25]

The CQ bit was unchecked by vmpstr@chromium.org

[vmpstr, 2017-02-28 22:11:30]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 22:12:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mthiesse, 2017-02-28 22:14:20]

On 2017/02/28 22:10:38, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

vr_shell/ lgtm

[vmpstr, 2017-02-28 22:21:52]

vmpstr@chromium.org changed reviewers:
+ cschuet@chromium.org

[vmpstr, 2017-02-28 22:21:53]

+cschuet for chromeos/network/. Please take a look.

[commit-bot: I haz the power, 2017-02-28 22:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:25:05]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[vmpstr, 2017-02-28 22:29:46]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 22:30:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 22:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:51:55]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[vmpstr, 2017-02-28 23:18:46]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:19:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 00:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 00:41:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2017-03-01 18:46:19]

Description was changed from

==========
Remove auto raw pointer deduction from non-linux specific code.

This patch removes the rest of the auto raw pointer deduction as
detected the a clang plugin. This should be enough to enable the check
for all platforms.

R=danakj@chromium.org
BUG=554600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove auto raw pointer deduction from non-linux specific code.

This patch removes the rest of the auto raw pointer deduction as
detected the a clang plugin. This should be enough to enable the check
for all platforms.

R=danakj@chromium.org
TBR=cschuet@chromium.org
BUG=554600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[vmpstr, 2017-03-01 18:46:43]

TBRing cschuet

[vmpstr, 2017-03-01 18:46:52]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-03-01 18:46:52]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
vabr@chromium.org, mthiesse@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2721553004/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-01 18:47:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:15:08]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488394012076260,
"parent_rev": "1da0b00909796cae61b947e76830fdfa67d6802c", "commit_rev":
"843b41a25f71a9980dbfe2f5a70407efd0ef2ea2"}

[commit-bot: I haz the power, 2017-03-01 21:15:50]

Description was changed from

==========
Remove auto raw pointer deduction from non-linux specific code.

This patch removes the rest of the auto raw pointer deduction as
detected the a clang plugin. This should be enough to enable the check
for all platforms.

R=danakj@chromium.org
TBR=cschuet@chromium.org
BUG=554600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove auto raw pointer deduction from non-linux specific code.

This patch removes the rest of the auto raw pointer deduction as
detected the a clang plugin. This should be enough to enable the check
for all platforms.

R=danakj@chromium.org
TBR=cschuet@chromium.org
BUG=554600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2721553004
Cr-Commit-Position: refs/heads/master@{#454029}
Committed:
https://chromium.googlesource.com/chromium/src/+/843b41a25f71a9980dbfe2f5a704...
==========

[commit-bot: I haz the power, 2017-03-01 21:15:53]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/843b41a25f71a9980dbfe2f5a704...