Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: chrome/browser/chromeos/note_taking_helper.cc

Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/note_taking_helper.cc
diff --git a/chrome/browser/chromeos/note_taking_helper.cc b/chrome/browser/chromeos/note_taking_helper.cc
index 4b7fdf1925dfe56d653d3df3cdcda022bf02445e..159af5ed933d15fa881047716aea9a61c3faa0cf 100644
--- a/chrome/browser/chromeos/note_taking_helper.cc
+++ b/chrome/browser/chromeos/note_taking_helper.cc
@@ -122,7 +122,7 @@ NoteTakingAppInfos NoteTakingHelper::GetAvailableApps(Profile* profile) {
const std::vector<const extensions::Extension*> chrome_apps =
GetChromeApps(profile);
- for (const auto& app : chrome_apps)
+ for (const auto* app : chrome_apps)
infos.push_back(NoteTakingAppInfo{app->name(), app->id(), false});
if (arc::IsArcAllowedForProfile(profile))
@@ -233,12 +233,12 @@ NoteTakingHelper::NoteTakingHelper()
}
// Watch for changes of Google Play Store enabled state.
- auto session_manager = arc::ArcSessionManager::Get();
+ auto* session_manager = arc::ArcSessionManager::Get();
session_manager->AddObserver(this);
// ArcIntentHelperBridge will notify us about changes to the list of available
// Android apps.
- auto intent_helper_bridge =
+ auto* intent_helper_bridge =
arc::ArcServiceManager::GetGlobalService<arc::ArcIntentHelperBridge>();
if (intent_helper_bridge)
intent_helper_bridge->AddObserver(this);
@@ -258,7 +258,7 @@ NoteTakingHelper::~NoteTakingHelper() {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
// ArcSessionManagerTest shuts down ARC before NoteTakingHelper.
- auto intent_helper_bridge =
+ auto* intent_helper_bridge =
arc::ArcServiceManager::GetGlobalService<arc::ArcIntentHelperBridge>();
if (intent_helper_bridge)
intent_helper_bridge->RemoveObserver(this);
@@ -391,7 +391,7 @@ void NoteTakingHelper::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
DCHECK_EQ(type, chrome::NOTIFICATION_PROFILE_ADDED);
- auto registry = extensions::ExtensionRegistry::Get(
+ auto* registry = extensions::ExtensionRegistry::Get(
content::Source<Profile>(source).ptr());
DCHECK(!extension_registry_observer_.IsObserving(registry));
extension_registry_observer_.Add(registry);

Powered by Google App Engine
This is Rietveld 408576698