ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm - Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm

Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm

diff --git a/ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm b/ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm

index c096c432b12b61a1dd06115317cf07c6dba555b3..50f8daca50b9761733a11ccfadb3c95b7d699b5c 100644

--- a/ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm

+++ b/ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm

@@ -289,7 +289,7 @@ initWithLargeIconService:(favicon::LargeIconService*)largeIconService

NSMutableDictionary* spotlightItems = [[NSMutableDictionary alloc] init];

std::vector<const bookmarks::BookmarkNode*> nodes;

_bookmarkModel->GetNodesByURL(URL, &nodes);

- for (auto node : nodes) {

+ for (auto* node : nodes) {

NSString* nodeTitle = base::SysUTF16ToNSString(node->GetTitle());

NSString* spotlightID = [self spotlightIDForURL:URL title:nodeTitle];

CSSearchableItem* item = [spotlightItems objectForKey:spotlightID];