Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: components/crash/content/browser/crash_dump_observer_android.cc

Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/network/geolocation_handler.cc ('k') | components/crash/core/common/objc_zombie.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/crash/content/browser/crash_dump_observer_android.h" 5 #include "components/crash/content/browser/crash_dump_observer_android.h"
6 6
7 #include <unistd.h> 7 #include <unistd.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 content::ProcessType process_type, 68 content::ProcessType process_type,
69 base::TerminationStatus termination_status, 69 base::TerminationStatus termination_status,
70 base::android::ApplicationState app_state) { 70 base::android::ApplicationState app_state) {
71 DCHECK_CURRENTLY_ON(BrowserThread::UI); 71 DCHECK_CURRENTLY_ON(BrowserThread::UI);
72 std::vector<Client*> registered_clients_copy; 72 std::vector<Client*> registered_clients_copy;
73 { 73 {
74 base::AutoLock auto_lock(registered_clients_lock_); 74 base::AutoLock auto_lock(registered_clients_lock_);
75 for (auto& client : registered_clients_) 75 for (auto& client : registered_clients_)
76 registered_clients_copy.push_back(client.get()); 76 registered_clients_copy.push_back(client.get());
77 } 77 }
78 for (auto& client : registered_clients_copy) { 78 for (auto* client : registered_clients_copy) {
79 client->OnChildExit(child_process_id, pid, process_type, termination_status, 79 client->OnChildExit(child_process_id, pid, process_type, termination_status,
80 app_state); 80 app_state);
81 } 81 }
82 } 82 }
83 83
84 void CrashDumpObserver::BrowserChildProcessStarted( 84 void CrashDumpObserver::BrowserChildProcessStarted(
85 int child_process_id, 85 int child_process_id,
86 content::FileDescriptorInfo* mappings) { 86 content::FileDescriptorInfo* mappings) {
87 DCHECK_CURRENTLY_ON(BrowserThread::PROCESS_LAUNCHER); 87 DCHECK_CURRENTLY_ON(BrowserThread::PROCESS_LAUNCHER);
88 std::vector<Client*> registered_clients_copy; 88 std::vector<Client*> registered_clients_copy;
89 { 89 {
90 base::AutoLock auto_lock(registered_clients_lock_); 90 base::AutoLock auto_lock(registered_clients_lock_);
91 for (auto& client : registered_clients_) 91 for (auto& client : registered_clients_)
92 registered_clients_copy.push_back(client.get()); 92 registered_clients_copy.push_back(client.get());
93 } 93 }
94 for (auto& client : registered_clients_copy) { 94 for (auto* client : registered_clients_copy) {
95 client->OnChildStart(child_process_id, mappings); 95 client->OnChildStart(child_process_id, mappings);
96 } 96 }
97 } 97 }
98 98
99 void CrashDumpObserver::BrowserChildProcessHostDisconnected( 99 void CrashDumpObserver::BrowserChildProcessHostDisconnected(
100 const content::ChildProcessData& data) { 100 const content::ChildProcessData& data) {
101 DCHECK_CURRENTLY_ON(BrowserThread::UI); 101 DCHECK_CURRENTLY_ON(BrowserThread::UI);
102 OnChildExit(data.id, data.handle, 102 OnChildExit(data.id, data.handle,
103 static_cast<content::ProcessType>(data.process_type), 103 static_cast<content::ProcessType>(data.process_type),
104 base::TERMINATION_STATUS_MAX_ENUM, 104 base::TERMINATION_STATUS_MAX_ENUM,
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 if (pid == base::kNullProcessHandle) { 161 if (pid == base::kNullProcessHandle) {
162 pid = iter->second; 162 pid = iter->second;
163 } 163 }
164 child_process_id_to_pid_.erase(iter); 164 child_process_id_to_pid_.erase(iter);
165 } 165 }
166 OnChildExit(rph->GetID(), pid, content::PROCESS_TYPE_RENDERER, term_status, 166 OnChildExit(rph->GetID(), pid, content::PROCESS_TYPE_RENDERER, term_status,
167 app_state); 167 app_state);
168 } 168 }
169 169
170 } // namespace breakpad 170 } // namespace breakpad
OLDNEW
« no previous file with comments | « chromeos/network/geolocation_handler.cc ('k') | components/crash/core/common/objc_zombie.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698