Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: ios/chrome/browser/payments/payment_request.mm

Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/payments/payment_request.mm
diff --git a/ios/chrome/browser/payments/payment_request.mm b/ios/chrome/browser/payments/payment_request.mm
index 3d959a11a6a709667dfb1877848598076deb7db1..5ff29f57f98e7e8d8bbbf45d10c4c29720c23a8b 100644
--- a/ios/chrome/browser/payments/payment_request.mm
+++ b/ios/chrome/browser/payments/payment_request.mm
@@ -54,7 +54,7 @@ payments::CurrencyFormatter* PaymentRequest::GetOrCreateCurrencyFormatter() {
}
void PaymentRequest::PopulateProfileCache() {
- for (const auto& profile : personal_data_manager_->GetProfilesToSuggest()) {
+ for (const auto* profile : personal_data_manager_->GetProfilesToSuggest()) {
profile_cache_.push_back(
base::MakeUnique<autofill::AutofillProfile>(*profile));
shipping_profiles_.push_back(profile_cache_.back().get());
@@ -82,7 +82,7 @@ void PaymentRequest::PopulateCreditCardCache() {
std::vector<autofill::CreditCard*> credit_cards =
personal_data_manager_->GetCreditCardsToSuggest();
- for (const auto& credit_card : credit_cards) {
+ for (const auto* credit_card : credit_cards) {
std::string spec_card_type =
autofill::data_util::GetPaymentRequestData(credit_card->type())
.basic_card_payment_type;
@@ -111,7 +111,7 @@ void PaymentRequest::PopulateShippingOptionCache() {
[](web::PaymentShippingOption& option) { return &option; });
selected_shipping_option_ = nullptr;
- for (const auto& shipping_option : shipping_options_) {
+ for (auto* shipping_option : shipping_options_) {
if (shipping_option->selected) {
// If more than one option has |selected| set, the last one in the
// sequence should be treated as the selected item.

Powered by Google App Engine
This is Rietveld 408576698