//third_party/WebKit/Source/bindings: include v8 as a user, not system, header

//third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Note: due to an issue with v8's GN files, files that use include v8
inspector headers are being skipped for now.

BUG=688155
Review-Url: https://codereview.chromium.org/2721533003
Cr-Commit-Position: refs/heads/master@{#453409}
Committed: https://chromium.googlesource.com/chromium/src/+/43cf179651d67978fa112f436b17359a688a321e

[dcheng, 2017-02-27 09:38:31]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org

[dcheng, 2017-02-27 09:38:33]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 09:38:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-27 09:44:57]

LGTM

[dcheng, 2017-02-27 09:45:47]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2017-02-27 09:45:47]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-02-27 09:45:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 09:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 09:53:46]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2017-02-27 22:14:29]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2017-02-27 22:14:29]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2721533003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-02-27 22:15:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:24:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488233669128880,
"parent_rev": "98d7a599f145f9e5ad5b5f6a47dc1998045f16c8", "commit_rev":
"43cf179651d67978fa112f436b17359a688a321e"}

[commit-bot: I haz the power, 2017-02-28 00:25:36]

Description was changed from

==========
//third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Note: due to an issue with v8's GN files, files that use include v8
inspector headers are being skipped for now.

BUG=688155
==========

to

==========
//third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Note: due to an issue with v8's GN files, files that use include v8
inspector headers are being skipped for now.

BUG=688155

Review-Url: https://codereview.chromium.org/2721533003
Cr-Commit-Position: refs/heads/master@{#453409}
Committed:
https://chromium.googlesource.com/chromium/src/+/43cf179651d67978fa112f436b17...
==========

[commit-bot: I haz the power, 2017-02-28 00:25:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/43cf179651d67978fa112f436b17...

[Michael Hablich, 2017-03-02 11:16:27]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2723313003/ by hablich@chromium.org.

The reason for reverting is: Prevents rolling in V8 5.8. Please heed the API
freeze in the future. See
https://build.chromium.org/p/chromium.fyi/builders/Linux%20V8%20API%20Stabili...
for more information..

[Michael Achenbach, 2017-03-02 11:22:34]

Note that this also broke normal V8 api stability (beyond the fact that we have
api freeze due to branching):
https://build.chromium.org/p/chromium.fyi/builders/Linux%20V8%20API%20Stabili...

Usually we'd like to have a minimum 2-3 window between v8 and dependent chromium
changes to always be able to revert v8 to the last good canary. That's what the
fyi bot checks.

[Michael Achenbach, 2017-03-02 11:45:18]

On 2017/03/02 11:22:34, Michael Achenbach wrote:
> Note that this also broke normal V8 api stability (beyond the fact that we
have
> api freeze due to branching):
>
https://build.chromium.org/p/chromium.fyi/builders/Linux%20V8%20API%20Stabili...
> 
> Usually we'd like to have a minimum 2-3 window between v8 and dependent
chromium
> changes to always be able to revert v8 to the last good canary. That's what
the
> fyi bot checks.

Since the revert doesn't stick we proceeded with cherry-picking the v8 side
change:
https://chromium-review.googlesource.com/c/448577/

We'll land that one on the release branch and in the chromium roll branch.