third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp - Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

index cf19eabe9333faf57ed065afa5629d8f155b9349..92df40a7cfb5f06303742324087b121d470dc51d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

@@ -4,6 +4,8 @@

#include "bindings/core/v8/ScriptPromiseResolver.h"

+#include <memory>

#include "bindings/core/v8/ScriptFunction.h"

#include "bindings/core/v8/ScriptValue.h"

#include "bindings/core/v8/V8Binding.h"

@@ -11,8 +13,7 @@

#include "core/dom/Document.h"

#include "core/testing/DummyPageHolder.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include <memory>

-#include <v8.h>

+#include "v8/include/v8.h"

namespace blink {