third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h - Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h b/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

index 465dcecfb78db4726e8707b13c34dc077b3706f6..1d9460964cc3384ba6d1700744946c9ee6daef0c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

@@ -31,11 +31,12 @@

#ifndef ScopedPersistent_h

#define ScopedPersistent_h

+#include <memory>

#include "bindings/core/v8/ScriptWrappableVisitor.h"

+#include "v8/include/v8.h"

#include "wtf/Allocator.h"

#include "wtf/Noncopyable.h"

-#include <memory>

-#include <v8.h>

namespace blink {