third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp - Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

index 088ceb751c452441980f37aa5b10ba6b57d042f6..e2ff890f925ca7940ff3c773614c82c59a357c8b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

@@ -30,7 +30,6 @@

#include "bindings/core/v8/LocalWindowProxy.h"

-#include <v8.h>

#include "bindings/core/v8/ConditionalFeaturesForCore.h"

#include "bindings/core/v8/DOMWrapperWorld.h"

#include "bindings/core/v8/ScriptController.h"

@@ -57,6 +56,7 @@

#include "platform/heap/Handle.h"

#include "platform/instrumentation/tracing/TraceEvent.h"

#include "platform/weborigin/SecurityOrigin.h"

+#include "v8/include/v8.h"

#include "wtf/Assertions.h"

namespace blink {