third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp - Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

index 4bee2dffd2a16a2627c72a98da1fd8e969bf1369..a288368cffec12c6d83b924d531fe5e3adfd9369 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

@@ -4,6 +4,8 @@

#include "bindings/core/v8/ScriptPromiseProperty.h"

+#include <memory>

#include "bindings/core/v8/DOMWrapperWorld.h"

#include "bindings/core/v8/ScriptFunction.h"

#include "bindings/core/v8/ScriptPromise.h"

@@ -18,10 +20,9 @@

#include "core/testing/GarbageCollectedScriptWrappable.h"

#include "platform/heap/Handle.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "v8/include/v8.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

-#include <memory>

-#include <v8.h>

namespace blink {