third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp - Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

index 687d1d0ecf39e8dd826c7680eb4e3fddaa2eb9b8..ac8405e3b04e684d4b983942672d99413e1c6d1f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -25,9 +25,8 @@

#include "bindings/core/v8/V8Initializer.h"

-#include <v8-debug.h>

-#include <v8-profiler.h>

#include <memory>

#include "bindings/core/v8/DOMWrapperWorld.h"

#include "bindings/core/v8/RejectedPromises.h"

#include "bindings/core/v8/RetainedDOMInfo.h"

@@ -61,6 +60,8 @@

#include "public/platform/Platform.h"

#include "public/platform/WebScheduler.h"

#include "public/platform/WebThread.h"

+#include "v8/include/v8-debug.h"

+#include "v8/include/v8-profiler.h"

#include "wtf/AddressSanitizer.h"

#include "wtf/Assertions.h"

#include "wtf/PtrUtil.h"