third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h - Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

Issue 2721533003: //third_party/WebKit/Source/bindings: include v8 as a user, not system, header (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

index 8c359827242e034dc521c3e3d3009d19ff8ebe13..624735e6541a5e5d7d057b824941cd7f86795f56 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

@@ -5,16 +5,17 @@

#ifndef ScriptPromisePropertyBase_h

#define ScriptPromisePropertyBase_h

+#include <memory>

#include "bindings/core/v8/ScopedPersistent.h"

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptPromiseProperties.h"

#include "core/CoreExport.h"

#include "core/dom/ContextLifecycleObserver.h"

+#include "v8/include/v8.h"

#include "wtf/Compiler.h"

#include "wtf/RefCounted.h"

#include "wtf/Vector.h"

-#include <memory>

-#include <v8.h>

namespace blink {