Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL to have [RaisesException].

BUG=692665
Review-Url: https://codereview.chromium.org/2697923005
Cr-Commit-Position: refs/heads/master@{#451259}
Committed: https://chromium.googlesource.com/chromium/src/+/050bd3b819cc8502db03e3b70f97e951c66e4857

[hayato, 2017-02-16 09:37:32]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 09:38:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2017-02-16 09:39:57]

Description was changed from

==========
Remove unnecessary histrocal override of Node::cloneNode in
ShadowRoot::cloneNode()

ShadowRoot's IDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

BUG=69226
==========

to

==========
Remove unnecessary histrocal override of Node::cloneNode in
ShadowRoot::cloneNode()

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL so it has [RaiseException].

BUG=692665
==========

[hayato, 2017-02-16 09:40:37]

Description was changed from

==========
Remove unnecessary histrocal override of Node::cloneNode in
ShadowRoot::cloneNode()

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL so it has [RaiseException].

BUG=692665
==========

to

==========
Remove unnecessary histrocal override of Node::cloneNode in
ShadowRoot::cloneNode()

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL to have [RaisesException].

BUG=692665
==========

[hayato, 2017-02-16 09:43:24]

hayato@chromium.org changed reviewers:
+ foolip@chromium.org, tkent@chromium.org

[hayato, 2017-02-16 09:43:26]

PTAL

[hayato, 2017-02-16 09:43:47]

Description was changed from

==========
Remove unnecessary histrocal override of Node::cloneNode in
ShadowRoot::cloneNode()

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL to have [RaisesException].

BUG=692665
==========

to

==========
Remove unnecessary override of Node::cloneNode in ShadowRoot::cloneNode()

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL to have [RaisesException].

BUG=692665
==========

[hayato, 2017-02-16 09:44:43]

Description was changed from

==========
Remove unnecessary override of Node::cloneNode in ShadowRoot::cloneNode()

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL to have [RaisesException].

BUG=692665
==========

to

==========
Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL to have [RaisesException].

BUG=692665
==========

[commit-bot: I haz the power, 2017-02-16 11:07:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 11:07:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[foolip, 2017-02-16 13:56:12]

lgtm % nit

https://codereview.chromium.org/2697923005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h (right):

https://codereview.chromium.org/2697923005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h:176: // Node*
cloneNode(bool, ExceptionState&) override { return nullptr; }
Can you remove this and instead add override to the cloneNode above? (It
previously wasn't an override.)

[tkent, 2017-02-17 01:50:43]

Please update the results of webexposed/global-interface-listing.html.

[hayato, 2017-02-17 05:07:26]

addressed

[hayato, 2017-02-17 05:07:28]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 05:08:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2017-02-17 05:09:14]

Thank you for the reviews.

I have updated webexposed/global-interface-listing.html.

https://codereview.chromium.org/2697923005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h (right):

https://codereview.chromium.org/2697923005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h:176: // Node*
cloneNode(bool, ExceptionState&) override { return nullptr; }
Done

[tkent, 2017-02-17 05:12:58]

You need to update
LayoutTests/platform/{mac,win}/virtual/stable/webexposed/global-interface-listing-expected.txt
too.

[hayato, 2017-02-17 05:54:34]

updated {mac,win} global-interface-listing-expected.txt

[hayato, 2017-02-17 05:54:35]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 05:55:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2017-02-17 05:55:49]

DONE.

[tkent, 2017-02-17 06:09:29]

lgtm

[hayato, 2017-02-17 06:14:05]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2017-02-17 06:14:08]

The CQ bit was checked by hayato@chromium.org

[hayato, 2017-02-17 06:14:08]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2697923005/#ps40001
(title: "updated {mac,win} global-interface-listing-expected.txt")

[commit-bot: I haz the power, 2017-02-17 06:14:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 07:13:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487312048329750,
"parent_rev": "fc272fcee054fe36d29911452c64957e092c9079", "commit_rev":
"050bd3b819cc8502db03e3b70f97e951c66e4857"}

[commit-bot: I haz the power, 2017-02-17 07:14:29]

Description was changed from

==========
Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL to have [RaisesException].

BUG=692665
==========

to

==========
Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

ShadowRoot's WebIDL does not have to override Node's cloneNode().
That exists for a historical reason, which is no longer valid.

Align Node's WebIDL to have [RaisesException].

BUG=692665

Review-Url: https://codereview.chromium.org/2697923005
Cr-Commit-Position: refs/heads/master@{#451259}
Committed:
https://chromium.googlesource.com/chromium/src/+/050bd3b819cc8502db03e3b70f97...
==========

[commit-bot: I haz the power, 2017-02-17 07:14:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/050bd3b819cc8502db03e3b70f97...