third_party/WebKit/Source/core/dom/Comment.cpp - Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Comment.cpp

Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL (Closed)

Patch Set: updated {mac,win} global-interface-listing-expected.txt Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Comment.cpp

diff --git a/third_party/WebKit/Source/core/dom/Comment.cpp b/third_party/WebKit/Source/core/dom/Comment.cpp

index f9d4d59a373ee0aaf69f77d834da6d1b704447b4..bde352af8e6f3d40faee3d5e505017f9846cae3e 100644

--- a/third_party/WebKit/Source/core/dom/Comment.cpp

+++ b/third_party/WebKit/Source/core/dom/Comment.cpp

@@ -40,7 +40,7 @@ Node::NodeType Comment::getNodeType() const {

return kCommentNode;

}

-Node* Comment::cloneNode(bool /*deep*/) {

+Node* Comment::cloneNode(bool /*deep*/, ExceptionState&) {

return create(document(), data());

}