third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp - Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL (Closed)

Patch Set: updated {mac,win} global-interface-listing-expected.txt Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

diff --git a/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp b/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

index 9a6bc3448038110439c25478cd468569d33d2a86..56eebfafa6362cc3964e3fecfba0dfb2732fafeb 100644

--- a/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

+++ b/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

@@ -79,7 +79,7 @@ Node::NodeType ProcessingInstruction::getNodeType() const {

return kProcessingInstructionNode;

}

-Node* ProcessingInstruction::cloneNode(bool /*deep*/) {

+Node* ProcessingInstruction::cloneNode(bool /*deep*/, ExceptionState&) {

// FIXME: Is it a problem that this does not copy m_localHref?

// What about other data members?

return create(document(), m_target, m_data);