third_party/WebKit/Source/core/dom/Text.h - Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Text.h

Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL (Closed)

Patch Set: updated {mac,win} global-interface-listing-expected.txt Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Text.h

diff --git a/third_party/WebKit/Source/core/dom/Text.h b/third_party/WebKit/Source/core/dom/Text.h

index ea36fc688b4c6cfc898b182f5b7d2a376012bbc9..7c865df308f78764bbe377ff4fb22e376fd7d479 100644

--- a/third_party/WebKit/Source/core/dom/Text.h

+++ b/third_party/WebKit/Source/core/dom/Text.h

@@ -75,7 +75,7 @@ class CORE_EXPORT Text : public CharacterData {

private:

String nodeName() const override;

- Node* cloneNode(bool deep) final;

+ Node* cloneNode(bool deep, ExceptionState&) final;

bool isTextNode() const =

delete; // This will catch anyone doing an unnecessary check.