third_party/WebKit/Source/core/dom/Comment.h - Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Comment.h

Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL (Closed)

Patch Set: updated {mac,win} global-interface-listing-expected.txt Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Comment.h

diff --git a/third_party/WebKit/Source/core/dom/Comment.h b/third_party/WebKit/Source/core/dom/Comment.h

index c4c9be199e69cdc3ba96c08c7618d54b46360bae..449f882c121f4e6198ebebfd80e1d157f8c6e779 100644

--- a/third_party/WebKit/Source/core/dom/Comment.h

+++ b/third_party/WebKit/Source/core/dom/Comment.h

@@ -38,7 +38,7 @@ class Comment final : public CharacterData {

String nodeName() const override;

NodeType getNodeType() const override;

- Node* cloneNode(bool deep) override;

+ Node* cloneNode(bool deep, ExceptionState&) override;

};

DEFINE_NODE_TYPE_CASTS(Comment, getNodeType() == Node::kCommentNode);