Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL (Closed)
Patch Set: updated {mac,win} global-interface-listing-expected.txt Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Peter Kelly (pmk@post.com) 2 * Copyright (C) 2000 Peter Kelly (pmk@post.com)
3 * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 } 72 }
73 73
74 String ProcessingInstruction::nodeName() const { 74 String ProcessingInstruction::nodeName() const {
75 return m_target; 75 return m_target;
76 } 76 }
77 77
78 Node::NodeType ProcessingInstruction::getNodeType() const { 78 Node::NodeType ProcessingInstruction::getNodeType() const {
79 return kProcessingInstructionNode; 79 return kProcessingInstructionNode;
80 } 80 }
81 81
82 Node* ProcessingInstruction::cloneNode(bool /*deep*/) { 82 Node* ProcessingInstruction::cloneNode(bool /*deep*/, ExceptionState&) {
83 // FIXME: Is it a problem that this does not copy m_localHref? 83 // FIXME: Is it a problem that this does not copy m_localHref?
84 // What about other data members? 84 // What about other data members?
85 return create(document(), m_target, m_data); 85 return create(document(), m_target, m_data);
86 } 86 }
87 87
88 void ProcessingInstruction::didAttributeChanged() { 88 void ProcessingInstruction::didAttributeChanged() {
89 if (m_sheet) 89 if (m_sheet)
90 clearSheet(); 90 clearSheet();
91 91
92 String href; 92 String href;
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 } 292 }
293 293
294 DEFINE_TRACE(ProcessingInstruction) { 294 DEFINE_TRACE(ProcessingInstruction) {
295 visitor->trace(m_sheet); 295 visitor->trace(m_sheet);
296 visitor->trace(m_listenerForXSLT); 296 visitor->trace(m_listenerForXSLT);
297 CharacterData::trace(visitor); 297 CharacterData::trace(visitor);
298 ResourceOwner<StyleSheetResource>::trace(visitor); 298 ResourceOwner<StyleSheetResource>::trace(visitor);
299 } 299 }
300 300
301 } // namespace blink 301 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/ProcessingInstruction.h ('k') | third_party/WebKit/Source/core/dom/Text.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698