Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL (Closed)
Patch Set: updated {mac,win} global-interface-listing-expected.txt Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.h ('k') | third_party/WebKit/Source/core/dom/Node.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 EVisibility::kVisible; 242 EVisibility::kVisible;
243 } 243 }
244 244
245 // FIXME: Even if we are not visible, we might have a child that is visible. 245 // FIXME: Even if we are not visible, we might have a child that is visible.
246 // Hyatt wants to fix that some day with a "has visible content" flag or the 246 // Hyatt wants to fix that some day with a "has visible content" flag or the
247 // like. 247 // like.
248 return layoutObject() && 248 return layoutObject() &&
249 layoutObject()->style()->visibility() == EVisibility::kVisible; 249 layoutObject()->style()->visibility() == EVisibility::kVisible;
250 } 250 }
251 251
252 Node* Element::cloneNode(bool deep) { 252 Node* Element::cloneNode(bool deep, ExceptionState&) {
253 return deep ? cloneElementWithChildren() : cloneElementWithoutChildren(); 253 return deep ? cloneElementWithChildren() : cloneElementWithoutChildren();
254 } 254 }
255 255
256 Element* Element::cloneElementWithChildren() { 256 Element* Element::cloneElementWithChildren() {
257 Element* clone = cloneElementWithoutChildren(); 257 Element* clone = cloneElementWithoutChildren();
258 cloneChildNodes(clone); 258 cloneChildNodes(clone);
259 return clone; 259 return clone;
260 } 260 }
261 261
262 Element* Element::cloneElementWithoutChildren() { 262 Element* Element::cloneElementWithoutChildren() {
(...skipping 3871 matching lines...) Expand 10 before | Expand all | Expand 10 after
4134 } 4134 }
4135 4135
4136 DEFINE_TRACE_WRAPPERS(Element) { 4136 DEFINE_TRACE_WRAPPERS(Element) {
4137 if (hasRareData()) { 4137 if (hasRareData()) {
4138 visitor->traceWrappers(elementRareData()); 4138 visitor->traceWrappers(elementRareData());
4139 } 4139 }
4140 ContainerNode::traceWrappers(visitor); 4140 ContainerNode::traceWrappers(visitor);
4141 } 4141 }
4142 4142
4143 } // namespace blink 4143 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.h ('k') | third_party/WebKit/Source/core/dom/Node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698