third_party/WebKit/Source/core/dom/Document.h - Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL (Closed)

Patch Set: updated {mac,win} global-interface-listing-expected.txt Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.h

diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h

index 0ed30f7f6a118dc3adb15e81e17427bd4be35319..fb0bc1e06e38e3200425d4cdafb90e06ff515d6c 100644

--- a/third_party/WebKit/Source/core/dom/Document.h

+++ b/third_party/WebKit/Source/core/dom/Document.h

@@ -1376,7 +1376,7 @@ class CORE_EXPORT Document : public ContainerNode,

String nodeName() const final;

NodeType getNodeType() const final;

bool childTypeAllowed(NodeType) const final;

- Node* cloneNode(bool deep) final;

+ Node* cloneNode(bool deep, ExceptionState&) final;

void cloneDataFromDocument(const Document&);

bool isSecureContextImpl(

const SecureContextCheck priviligeContextCheck) const;