Migrate WTF::HashSet::remove() to ::erase() [part 1]

Migrate WTF::HashSet::remove() to ::erase() [part 1]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2696183002
Cr-Commit-Position: refs/heads/master@{#451141}
Committed: https://chromium.googlesource.com/chromium/src/+/9caf6364ab67c04029f037ffecb96169b681a469

[pilgrim_google, 2017-02-15 16:38:22]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[pilgrim_google, 2017-02-15 16:38:26]

Description was changed from

==========
Migrate WTF::HashSet::remove() to ::erase() [part 1]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::HashSet::remove() to ::erase() [part 1]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-02-15 16:38:27]

Description was changed from

==========
Migrate WTF::HashSet::remove() to ::erase() [part 1]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WTF::HashSet::remove() to ::erase() [part 1]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[haraken, 2017-02-15 23:35:22]

LGTM

[pilgrim_google, 2017-02-16 02:59:53]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:01:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 03:29:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:29:03]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pilgrim_google, 2017-02-16 20:27:53]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-02-16 20:27:54]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2696183002/#ps20001
(title: "rebase, fix reference in CodeGeneratorInstrumentation.py")

[commit-bot: I haz the power, 2017-02-16 20:29:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 21:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 21:27:01]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pilgrim_google, 2017-02-16 21:30:32]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-02-16 21:30:38]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2696183002/#ps40001
(title: "one more platform-specific reference")

[commit-bot: I haz the power, 2017-02-16 21:33:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 23:55:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487280632064060,
"parent_rev": "2a8fffb92961a5e6fb1ca93d74123f1cd05119d5", "commit_rev":
"9caf6364ab67c04029f037ffecb96169b681a469"}

[commit-bot: I haz the power, 2017-02-16 23:56:19]

Description was changed from

==========
Migrate WTF::HashSet::remove() to ::erase() [part 1]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Migrate WTF::HashSet::remove() to ::erase() [part 1]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2696183002
Cr-Commit-Position: refs/heads/master@{#451141}
Committed:
https://chromium.googlesource.com/chromium/src/+/9caf6364ab67c04029f037ffecb9...
==========

[commit-bot: I haz the power, 2017-02-16 23:56:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9caf6364ab67c04029f037ffecb9...