third_party/WebKit/Source/core/page/Page.cpp - Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1] (Closed)

Patch Set: one more platform-specific reference Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index 23f5e9954f6d3befac17aa5893b26a1f72356b9c..d5771fbc942596547437f4eb2b820f1b20f1b343 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -524,8 +524,8 @@ void Page::willBeDestroyed() {

mainFrame->detach(FrameDetachType::Remove);

ASSERT(allPages().contains(this));

- allPages().remove(this);

- ordinaryPages().remove(this);

+ allPages().erase(this);

+ ordinaryPages().erase(this);

if (m_scrollingCoordinator)

m_scrollingCoordinator->willBeDestroyed();