third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp - Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp

Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1] (Closed)

Patch Set: one more platform-specific reference Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp

index 9f96c0b17c829526a308e3b4991122eb4d63a4f8..53335cfccaf6f2d52737d30bcfe3f29efe57c981 100644

--- a/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp

@@ -65,7 +65,7 @@ void SnapCoordinator::snapContainerDidChange(LayoutBox& snapContainer,

if (scrollSnapType == ScrollSnapTypeNone) {

// TODO(majidvp): Track and report these removals to CompositorWorker

// instance responsible for snapping

- m_snapContainers.remove(&snapContainer);

+ m_snapContainers.erase(&snapContainer);

snapContainer.clearSnapAreas();

} else {

m_snapContainers.insert(&snapContainer);