third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp - Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1] (Closed)

Patch Set: one more platform-specific reference Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/nfc/NFC.cpp ('k') | third_party/WebKit/Source/modules/sensor/SensorProxy.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "modules/notifications/ServiceWorkerRegistrationNotifications.h"	5 #include "modules/notifications/ServiceWorkerRegistrationNotifications.h"

6	6

7 #include "bindings/core/v8/CallbackPromiseAdapter.h"	7 #include "bindings/core/v8/CallbackPromiseAdapter.h"

8 #include "bindings/core/v8/ExceptionState.h"	8 #include "bindings/core/v8/ExceptionState.h"

9 #include "bindings/core/v8/ScriptPromiseResolver.h"	9 #include "bindings/core/v8/ScriptPromiseResolver.h"

10 #include "core/dom/ExecutionContext.h"	10 #include "core/dom/ExecutionContext.h"

(...skipping 176 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
187 NotificationResourcesLoader* loader) {	187 NotificationResourcesLoader* loader) {

188 DCHECK(m_loaders.contains(loader));	188 DCHECK(m_loaders.contains(loader));

189	189

190 WebNotificationManager* notificationManager =	190 WebNotificationManager* notificationManager =

191 Platform::current()->notificationManager();	191 Platform::current()->notificationManager();

192 DCHECK(notificationManager);	192 DCHECK(notificationManager);

193	193

194 notificationManager->showPersistent(	194 notificationManager->showPersistent(

195 WebSecurityOrigin(origin.get()), data, loader->getResources(),	195 WebSecurityOrigin(origin.get()), data, loader->getResources(),

196 m_registration->webRegistration(), std::move(callbacks));	196 m_registration->webRegistration(), std::move(callbacks));

197 m_loaders.remove(loader);	197 m_loaders.erase(loader);

198 }	198 }

199	199

200 } // namespace blink	200 } // namespace blink

OLD	NEW