third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1] (Closed)

Patch Set: one more platform-specific reference Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 6dc0e376cb0b3cb7a50f9a0b7437f727cf424722..43d2e28a0a2b1d4c6cd3292284c8ea87dcc2824b 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -1749,7 +1749,7 @@ WebViewImpl* WebViewImpl::fromPage(Page* page) {

void WebViewImpl::close() {

DCHECK(allInstances().contains(this));

- allInstances().remove(this);

+ allInstances().erase(this);

if (m_page) {

// Initiate shutdown for the entire frameset. This will cause a lot of