third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1] (Closed)

Patch Set: one more platform-specific reference Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xml/XPathParser.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

index 24472e9113c8d3df1c84301c02245d794aca0b2e..7959f89b3667131c98b3904b766722b17836abe1 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -558,7 +558,7 @@ void AXObjectCacheImpl::removeAXID(AXObject* object) {

ASSERT(!HashTraits<AXID>::isDeletedValue(objID));

ASSERT(m_idsInUse.contains(objID));

object->setAXObjectID(0);

- m_idsInUse.remove(objID);

+ m_idsInUse.erase(objID);

if (m_ariaOwnerToChildrenMapping.contains(objID)) {

Vector<AXID> childAXIDs = m_ariaOwnerToChildrenMapping.get(objID);

@@ -724,7 +724,7 @@ void AXObjectCacheImpl::updateAriaOwns(

idsChanged = true;

HashSet<AXID>* owners = m_idToAriaOwnersMapping.get(id);

if (owners) {

- owners->remove(owner->axObjectID());

+ owners->erase(owner->axObjectID());

if (owners->isEmpty())

m_idToAriaOwnersMapping.erase(id);

}