third_party/WebKit/Source/modules/nfc/NFC.cpp - Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/nfc/NFC.cpp

Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1] (Closed)

Patch Set: one more platform-specific reference Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/nfc/NFC.cpp

diff --git a/third_party/WebKit/Source/modules/nfc/NFC.cpp b/third_party/WebKit/Source/modules/nfc/NFC.cpp

index 4e00b63df56d3c128428ff8af30def3955598954..3c8ead0f55fc112ede7d91ecbea66b34ebd01430 100644

--- a/third_party/WebKit/Source/modules/nfc/NFC.cpp

+++ b/third_party/WebKit/Source/modules/nfc/NFC.cpp

@@ -738,7 +738,7 @@ void NFC::OnRequestCompleted(ScriptPromiseResolver* resolver,

if (!m_requests.contains(resolver))

return;

- m_requests.remove(resolver);

+ m_requests.erase(resolver);

if (error.is_null())

resolver->resolve();

else

@@ -803,7 +803,7 @@ void NFC::OnWatchRegistered(MessageCallback* callback,

ScriptPromiseResolver* resolver,

uint32_t id,

device::nfc::mojom::blink::NFCErrorPtr error) {

- m_requests.remove(resolver);

+ m_requests.erase(resolver);

// Invalid id was returned.

// https://w3c.github.io/web-nfc/#dom-nfc-watch