Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Issue 2696183002: Migrate WTF::HashSet::remove() to ::erase() [part 1] (Closed)
Patch Set: one more platform-specific reference Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
index 386b8070007675d1ad5cb0948d882a102099c3fa..9fdf8cce3e3931d12a8a9159810046923c06d7f2 100644
--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
@@ -428,7 +428,7 @@ void ResourceFetcher::makePreloadedResourceBlockOnloadIfNeeded(
resource->isLoadEventBlockingResourceType() &&
resource->isLinkPreload() && !request.isLinkPreload() &&
m_nonBlockingLoaders.contains(resource->loader())) {
- m_nonBlockingLoaders.remove(resource->loader());
+ m_nonBlockingLoaders.erase(resource->loader());
m_loaders.insert(resource->loader());
}
}
@@ -1222,7 +1222,7 @@ void ResourceFetcher::moveResourceLoaderToNonBlocking(ResourceLoader* loader) {
// TODO(yoav): Convert CHECK to DCHECK if no crash reports come in.
CHECK(m_loaders.contains(loader));
m_nonBlockingLoaders.insert(loader);
- m_loaders.remove(loader);
+ m_loaders.erase(loader);
}
bool ResourceFetcher::startLoad(Resource* resource) {
@@ -1268,9 +1268,9 @@ bool ResourceFetcher::startLoad(Resource* resource) {
void ResourceFetcher::removeResourceLoader(ResourceLoader* loader) {
DCHECK(loader);
if (m_loaders.contains(loader))
- m_loaders.remove(loader);
+ m_loaders.erase(loader);
else if (m_nonBlockingLoaders.contains(loader))
- m_nonBlockingLoaders.remove(loader);
+ m_nonBlockingLoaders.erase(loader);
else
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698