Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)

Created:
3 years ago by grt (UTC plus 2)
Modified:
3 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, grt+watch_chromium.org, wfh+watch_chromium.org, tommycli, pennymac+watch_chromium.org, caitkp+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fail tests fast if overriding the Windows registry fails. All calls to RegistryOverrideManager::OverrideRegistry are now wrapped in ASSERT_NO_FATAL_FAILURE, as are a few helper functions in RegistryOverrideManagerTest that should have been. BUG=688878 TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2692843002 Cr-Commit-Position: refs/heads/master@{#450288} Committed: https://chromium.googlesource.com/chromium/src/+/f6d7da245a926307dc9c59d35cb893d9b1d65d82

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync to position 450085 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -153 lines) Patch
M base/test/test_reg_util_win.h View 2 chunks +3 lines, -1 line 0 comments Download
M base/test/test_reg_util_win.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M base/test/test_reg_util_win_unittest.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/downgrade/user_data_downgrade_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_win_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_test_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/win/chrome_elf_init_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/install_static/install_util_unittest.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/install_static/product_install_details_unittest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/install_static/user_data_dir_win_unittest.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M chrome/installer/gcapi/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/gcapi/gcapi_last_run_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi_omaha_experiment_test.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/installer/gcapi/gcapi_reactivation_test.cc View 3 chunks +9 lines, -2 lines 0 comments Download
D chrome/installer/gcapi/gcapi_test_registry_overrider.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/installer/gcapi/gcapi_test_registry_overrider.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/installer/mini_installer/configuration_test.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/installer/setup/installer_state_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/installer/setup/update_active_setup_version_work_item_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/beacons_unittest.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/installer/util/delete_reg_value_work_item_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/installer/util/install_util_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/installer/util/product_state_unittest.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/scoped_user_protocol_entry_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/set_reg_value_work_item_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_elf/blacklist/test/blacklist_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_elf/chrome_elf_util_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_elf/nt_registry/nt_registry_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/browser_watcher/watcher_metrics_provider_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M rlz/test/rlz_test_helpers.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 36 (26 generated)
grt (UTC plus 2)
phajdan.jr@chromium.org: please review the whole CL brettw@chromium.org: TBR to you for the changes that trickle ...
3 years ago (2017-02-13 12:31:41 UTC) #16
Paweł Hajdan Jr.
LGTM w/ an optional suggestion. https://codereview.chromium.org/2692843002/diff/40001/base/test/test_reg_util_win.h File base/test/test_reg_util_win.h (right): https://codereview.chromium.org/2692843002/diff/40001/base/test/test_reg_util_win.h#newcode42 base/test/test_reg_util_win.h:42: // Calls to these ...
3 years ago (2017-02-13 15:55:35 UTC) #17
grt (UTC plus 2)
https://codereview.chromium.org/2692843002/diff/40001/base/test/test_reg_util_win.h File base/test/test_reg_util_win.h (right): https://codereview.chromium.org/2692843002/diff/40001/base/test/test_reg_util_win.h#newcode42 base/test/test_reg_util_win.h:42: // Calls to these functions must be wrapped in ...
3 years ago (2017-02-13 20:58:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692843002/40001
3 years ago (2017-02-13 20:59:59 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/363128)
3 years ago (2017-02-13 21:09:14 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692843002/60001
3 years ago (2017-02-13 21:23:19 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng/builds/687)
3 years ago (2017-02-14 01:06:28 UTC) #29
grt (UTC plus 2)
master.tryserver.chromium.win:win10_chromium_x64_rel_ng seems broken. attempting to land this without it.
3 years ago (2017-02-14 07:09:02 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692843002/60001
3 years ago (2017-02-14 07:09:26 UTC) #33
commit-bot: I haz the power
3 years ago (2017-02-14 07:15:30 UTC) #36
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f6d7da245a926307dc9c59d35cb8...

Powered by Google App Engine
This is Rietveld 408576698