Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1903)

Unified Diff: chrome/install_static/product_install_details_unittest.cc

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)
Patch Set: sync to position 450085 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/install_static/install_util_unittest.cc ('k') | chrome/install_static/user_data_dir_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/product_install_details_unittest.cc
diff --git a/chrome/install_static/product_install_details_unittest.cc b/chrome/install_static/product_install_details_unittest.cc
index cdea80c7196c9143ead6d666476e85b634c9a04f..c64c9006c3cd972193f34ddd07dc4972b3fa9b76 100644
--- a/chrome/install_static/product_install_details_unittest.cc
+++ b/chrome/install_static/product_install_details_unittest.cc
@@ -173,15 +173,19 @@ class MakeProductDetailsTest : public testing::TestWithParam<TestData> {
root_key_(test_data_.system_level ? HKEY_LOCAL_MACHINE
: HKEY_CURRENT_USER),
nt_root_key_(test_data_.system_level ? nt::HKLM : nt::HKCU) {
- base::string16 path;
- override_manager_.OverrideRegistry(root_key_, &path);
- nt::SetTestingOverride(nt_root_key_, path);
}
~MakeProductDetailsTest() {
nt::SetTestingOverride(nt_root_key_, base::string16());
}
+ void SetUp() override {
+ base::string16 path;
+ ASSERT_NO_FATAL_FAILURE(
+ override_manager_.OverrideRegistry(root_key_, &path));
+ nt::SetTestingOverride(nt_root_key_, path);
+ }
+
const TestData& test_data() const { return test_data_; }
void SetAp(const wchar_t* value) {
« no previous file with comments | « chrome/install_static/install_util_unittest.cc ('k') | chrome/install_static/user_data_dir_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698