chrome/installer/gcapi/gcapi_last_run_test.cc - Issue 2692843002: Fail tests fast if overriding the Windows registry fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi/gcapi_last_run_test.cc

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)

Patch Set: sync to position 450085 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/gcapi/gcapi_last_run_test.cc

diff --git a/chrome/installer/gcapi/gcapi_last_run_test.cc b/chrome/installer/gcapi/gcapi_last_run_test.cc

index 4652f3616e6ea3e322dc99944e8b5aba99746608..309a8c056d7d71ba5b4ad33841e1e87e75cdbda7 100644

--- a/chrome/installer/gcapi/gcapi_last_run_test.cc

+++ b/chrome/installer/gcapi/gcapi_last_run_test.cc

@@ -26,7 +26,8 @@ class GCAPILastRunTest : public ::testing::Test {

protected:

void SetUp() override {

// Override keys - this is undone during destruction.

- override_manager_.OverrideRegistry(HKEY_CURRENT_USER);

+ ASSERT_NO_FATAL_FAILURE(

+ override_manager_.OverrideRegistry(HKEY_CURRENT_USER));

// Create the client state key in the right places.

std::wstring reg_path(google_update::kRegPathClientState);