chrome_elf/nt_registry/nt_registry_unittest.cc - Issue 2692843002: Fail tests fast if overriding the Windows registry fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/nt_registry/nt_registry_unittest.cc

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)

Patch Set: sync to position 450085 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_elf/nt_registry/nt_registry_unittest.cc

diff --git a/chrome_elf/nt_registry/nt_registry_unittest.cc b/chrome_elf/nt_registry/nt_registry_unittest.cc

index d2020429fadbc20d9da8ee412c54612e3bc15766..0d54cb5f7533e0d89ca18a64037f57c17c7e1434 100644

--- a/chrome_elf/nt_registry/nt_registry_unittest.cc

+++ b/chrome_elf/nt_registry/nt_registry_unittest.cc

@@ -294,9 +294,11 @@ class NtRegistryTest : public testing::Test {

protected:

void SetUp() override {

base::string16 temp;

- override_manager_.OverrideRegistry(HKEY_CURRENT_USER, &temp);

+ ASSERT_NO_FATAL_FAILURE(

+ override_manager_.OverrideRegistry(HKEY_CURRENT_USER, &temp));

ASSERT_TRUE(nt::SetTestingOverride(nt::HKCU, temp));

- override_manager_.OverrideRegistry(HKEY_LOCAL_MACHINE, &temp);

+ ASSERT_NO_FATAL_FAILURE(

+ override_manager_.OverrideRegistry(HKEY_LOCAL_MACHINE, &temp));

ASSERT_TRUE(nt::SetTestingOverride(nt::HKLM, temp));

}