Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: base/test/test_reg_util_win.h

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)
Patch Set: sync to position 450085 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/test_reg_util_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_reg_util_win.h
diff --git a/base/test/test_reg_util_win.h b/base/test/test_reg_util_win.h
index 33bcd216a673be0985d4ccf0f33934e84edb003d..d74028afc4f3ac819cd5347f20879978d94fc8e0 100644
--- a/base/test/test_reg_util_win.h
+++ b/base/test/test_reg_util_win.h
@@ -39,6 +39,8 @@ class RegistryOverrideManager {
// Multiple overrides to the same hive are not supported and lead to undefined
// behavior.
// Optional return of the registry override path.
+ // Calls to these functions must be wrapped in ASSERT_NO_FATAL_FAILURE to
+ // ensure that tests do not proceeed in case of failure to override.
void OverrideRegistry(HKEY override);
void OverrideRegistry(HKEY override, base::string16* override_path);
@@ -53,7 +55,7 @@ class RegistryOverrideManager {
private:
HKEY override_;
- base::win::RegKey temp_key_;
+ base::string16 key_path_;
DISALLOW_COPY_AND_ASSIGN(ScopedRegistryKeyOverride);
};
« no previous file with comments | « no previous file | base/test/test_reg_util_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698