chrome/browser/extensions/api/messaging/native_messaging_test_util.cc - Issue 2692843002: Fail tests fast if overriding the Windows registry fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)

Patch Set: sync to position 450085 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/downgrade/user_data_downgrade_browsertest.cc ('k') | chrome/browser/google/google_update_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc b/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

index 085f6c1d05e899c98a7736a52d8fd289e47a42e1..783b0b656b0b7558ede34d1bf66e2455ea50f42a 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

@@ -77,7 +77,7 @@ void ScopedTestNativeMessagingHost::RegisterTestHost(bool user_level) {

#if defined(OS_WIN)

HKEY root_key = user_level ? HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE;

- registry_override_.OverrideRegistry(root_key);

+ ASSERT_NO_FATAL_FAILURE(registry_override_.OverrideRegistry(root_key));

#else

path_override_.reset(new base::ScopedPathOverride(

user_level ? chrome::DIR_USER_NATIVE_MESSAGING

« no previous file with comments | « chrome/browser/downgrade/user_data_downgrade_browsertest.cc ('k') | chrome/browser/google/google_update_win_unittest.cc » ('j') | no next file with comments »