Fail tests fast if overriding the Windows registry fails.

chrome/install_static/user_data_dir_win_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/test/test_reg_util_win.h"
 #include "chrome/install_static/install_details.h"
 #include "chrome/install_static/user_data_dir.h"
 #include "chrome_elf/nt_registry/nt_registry.h"
@@ skipping 53 matching lines @@
   EXPECT_EQ(L"<>|:", invalid);
 }
 
 TEST(UserDataDir, RegistrySettingsInHKLMOverrides) {
   std::wstring result, invalid;
 
   // Override the registry to say one value in HKLM, and confirm it takes
   // precedence over the command line in both implementations.
   registry_util::RegistryOverrideManager override_manager;
   base::string16 temp;
-  override_manager.OverrideRegistry(HKEY_LOCAL_MACHINE, &temp);
+  ASSERT_NO_FATAL_FAILURE(
+      override_manager.OverrideRegistry(HKEY_LOCAL_MACHINE, &temp));
   ScopedNTRegistryTestingOverride nt_override(nt::HKLM, temp);
 
   base::win::RegKey key(HKEY_LOCAL_MACHINE, kPolicyRegistryKey, KEY_WRITE);
   LONG rv = key.WriteValue(kUserDataDirRegistryKey, L"yyy");
   ASSERT_EQ(rv, ERROR_SUCCESS);
 
   install_static::GetUserDataDirectoryImpl(L"xxx", kFakeInstallConstants,
                                            &result, &invalid);
 
   EXPECT_TRUE(EndsWith(result, L"\\yyy"));
   EXPECT_EQ(std::wstring(), invalid);
 }
 
 TEST(UserDataDir, RegistrySettingsInHKCUOverrides) {
   std::wstring result, invalid;
 
   // Override the registry to say one value in HKCU, and confirm it takes
   // precedence over the command line in both implementations.
   registry_util::RegistryOverrideManager override_manager;
   base::string16 temp;
-  override_manager.OverrideRegistry(HKEY_CURRENT_USER, &temp);
+  ASSERT_NO_FATAL_FAILURE(
+      override_manager.OverrideRegistry(HKEY_CURRENT_USER, &temp));
   ScopedNTRegistryTestingOverride nt_override(nt::HKCU, temp);
 
   base::win::RegKey key(HKEY_CURRENT_USER, kPolicyRegistryKey, KEY_WRITE);
   LONG rv = key.WriteValue(kUserDataDirRegistryKey, L"yyy");
   ASSERT_EQ(rv, ERROR_SUCCESS);
 
   install_static::GetUserDataDirectoryImpl(L"xxx", kFakeInstallConstants,
                                            &result, &invalid);
 
   EXPECT_TRUE(EndsWith(result, L"\\yyy"));
   EXPECT_EQ(std::wstring(), invalid);
 }
 
 TEST(UserDataDir, RegistrySettingsInHKLMTakesPrecedenceOverHKCU) {
   std::wstring result, invalid;
 
   // Override the registry in both HKLM and HKCU, and confirm HKLM takes
   // precedence.
   registry_util::RegistryOverrideManager override_manager;
   base::string16 temp;
-  override_manager.OverrideRegistry(HKEY_LOCAL_MACHINE, &temp);
+  ASSERT_NO_FATAL_FAILURE(
+      override_manager.OverrideRegistry(HKEY_LOCAL_MACHINE, &temp));
   ScopedNTRegistryTestingOverride nt_override(nt::HKLM, temp);
   LONG rv;
   base::win::RegKey key1(HKEY_LOCAL_MACHINE, kPolicyRegistryKey, KEY_WRITE);
   rv = key1.WriteValue(kUserDataDirRegistryKey, L"111");
   ASSERT_EQ(rv, ERROR_SUCCESS);
 
-  override_manager.OverrideRegistry(HKEY_CURRENT_USER, &temp);
+  ASSERT_NO_FATAL_FAILURE(
+      override_manager.OverrideRegistry(HKEY_CURRENT_USER, &temp));
   ScopedNTRegistryTestingOverride nt_override2(nt::HKCU, temp);
   base::win::RegKey key2(HKEY_CURRENT_USER, kPolicyRegistryKey, KEY_WRITE);
   rv = key2.WriteValue(kUserDataDirRegistryKey, L"222");
   ASSERT_EQ(rv, ERROR_SUCCESS);
 
   install_static::GetUserDataDirectoryImpl(L"xxx", kFakeInstallConstants,
                                            &result, &invalid);
 
   EXPECT_TRUE(EndsWith(result, L"\\111"));
   EXPECT_EQ(std::wstring(), invalid);
 }
 
 TEST(UserDataDir, RegistrySettingWithPathExpansionHKCU) {
   std::wstring result, invalid;
 
   registry_util::RegistryOverrideManager override_manager;
   base::string16 temp;
-  override_manager.OverrideRegistry(HKEY_CURRENT_USER, &temp);
+  ASSERT_NO_FATAL_FAILURE(
+      override_manager.OverrideRegistry(HKEY_CURRENT_USER, &temp));
   ScopedNTRegistryTestingOverride nt_override(nt::HKCU, temp);
   base::win::RegKey key(HKEY_CURRENT_USER, kPolicyRegistryKey, KEY_WRITE);
   LONG rv = key.WriteValue(kUserDataDirRegistryKey, L"${windows}");
   ASSERT_EQ(rv, ERROR_SUCCESS);
 
   install_static::GetUserDataDirectoryImpl(L"xxx", kFakeInstallConstants,
                                            &result, &invalid);
 
   EXPECT_EQ(strlen("X:\\WINDOWS"), result.size());
   EXPECT_EQ(std::wstring::npos, result.find(L"${windows}"));
   std::wstring upper;
   std::transform(result.begin(), result.end(), std::back_inserter(upper),
                  toupper);
   EXPECT_TRUE(EndsWith(upper, L"\\WINDOWS"));
   EXPECT_EQ(std::wstring(), invalid);
 }
 
 }  // namespace
 }  // namespace install_static