chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc - Issue 2692843002: Fail tests fast if overriding the Windows registry fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)

Patch Set: sync to position 450085 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profile_resetter/triggered_profile_resetter_win_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

index 70d09fee2eb4861b39d01e61d6f8cb766507756a..0145a7dd1170478824ba439dcad078f5d5adbe51 100644

--- a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

@@ -183,7 +183,7 @@ TEST(SafeBrowsingEnvironmentDataCollectionWinTest, CollectRegistryData) {

// Ensure that all values and subkeys from the specified registry keys are

// correctly stored in the report.

registry_util::RegistryOverrideManager override_manager;

- override_manager.OverrideRegistry(HKEY_CURRENT_USER);

+ ASSERT_NO_FATAL_FAILURE(override_manager.OverrideRegistry(HKEY_CURRENT_USER));

const wchar_t kRootKey[] = L"Software\\TestKey";

const RegistryKeyInfo kRegKeysToCollect[] = {