Fix auto raw pointer deduction on linux

Fix auto raw pointer deduction on linux

This patch fixes all of the places where the auto raw
pointer deduction is happening on linux

R=danakj@chromium.org
BUG=554600
Review-Url: https://codereview.chromium.org/2691393002
Cr-Commit-Position: refs/heads/master@{#452312}
Committed: https://chromium.googlesource.com/chromium/src/+/6d9996c865dc8d6901d0a004ff676d1215f4593c

[vmpstr, 2017-02-14 22:23:55]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 22:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-02-14 23:02:59]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 23:03:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-02-15 00:30:57]

Description was changed from

==========
Enable check for auto raw pointer deduction on linux

BUG=
==========

to

==========
Enable check for auto raw pointer deduction on linux

This patch enables the auto raw pointer deduction check
on linux and fixes all of the places where the check is
currently triggered.

R=danakj@chromium.org
BUG=554600
==========

[vmpstr, 2017-02-15 00:30:58]

vmpstr@chromium.org changed reviewers:
+ danakj@chromium.org

[vmpstr, 2017-02-15 00:34:42]

Hi, can you please take a look for an overall review and I'll start tracking
down owners if it looks OK.

In general, the changes here are roughly the following:
const auto& -> "auto*" in for loops
const auto -> "auto*" in for loops
const auto& -> "auto* const" in non-for loops
const auto -> "auto* const" in non-for loops
auto& -> auto* (it seems that we didn't need auto*&)

After applying the fixits, I manually went through and updated places that were
(imo) making the pointer const unnecessarily.

[commit-bot: I haz the power, 2017-02-15 02:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 02:45:24]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-02-15 16:32:18]

is gud LGTM

[vmpstr, 2017-02-15 18:43:05]

vmpstr@chromium.org changed reviewers:
+ brettw@chromium.org

[vmpstr, 2017-02-15 18:43:07]

+brettw for global owners... Please take a look. I can find closer owners if you
prefer, but it seems like a lot of unrelated owners. 

The changes here are a result of enabling the clang plugin in the build file; I
also went through and manually fixed up a few cases where we ended up with
things like
auto* const instead of just auto*.

[vmpstr, 2017-02-15 19:03:14]

vmpstr@chromium.org changed reviewers:
+ thakis@chromium.org

[vmpstr, 2017-02-15 19:03:15]

Also +thakis for the build/ stuff just to ensure that this is how we should
enable the check.

[Nico, 2017-02-15 19:14:16]

lgtm, but i'd recommend to land the build/ change separately, so that if turning
on the check needs to be reverted/relanded a few times, they don't revert all
the other stuff in this cl

https://codereview.chromium.org/2691393002/diff/20001/build/config/clang/BUIL...
File build/config/clang/BUILD.gn (right):

https://codereview.chromium.org/2691393002/diff/20001/build/config/clang/BUIL...
build/config/clang/BUILD.gn:40: if (is_linux && !is_chromeos && !is_chromecast)
{
add todo comment to enable this elsewhere, with link to bug

[vmpstr, 2017-02-15 20:47:59]

On 2017/02/15 19:14:16, Nico wrote:
> lgtm, but i'd recommend to land the build/ change separately, so that if
turning
> on the check needs to be reverted/relanded a few times, they don't revert all
> the other stuff in this cl

Do idea, I removed the build changes from this CL and will set the enable part
separately.

> 
>
https://codereview.chromium.org/2691393002/diff/20001/build/config/clang/BUIL...
> File build/config/clang/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2691393002/diff/20001/build/config/clang/BUIL...
> build/config/clang/BUILD.gn:40: if (is_linux && !is_chromeos &&
!is_chromecast)
> {
> add todo comment to enable this elsewhere, with link to bug

[vmpstr, 2017-02-15 20:48:37]

On 2017/02/15 20:47:59, vmpstr wrote:
> On 2017/02/15 19:14:16, Nico wrote:
> > lgtm, but i'd recommend to land the build/ change separately, so that if
> turning
> > on the check needs to be reverted/relanded a few times, they don't revert
all
> > the other stuff in this cl
> 
> Do idea, I removed the build changes from this CL and will set the enable part
> separately.

Err.. s/Do/Good/. and err s/set/send/
> 
> > 
> >
>
https://codereview.chromium.org/2691393002/diff/20001/build/config/clang/BUIL...
> > File build/config/clang/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2691393002/diff/20001/build/config/clang/BUIL...
> > build/config/clang/BUILD.gn:40: if (is_linux && !is_chromeos &&
> !is_chromecast)
> > {
> > add todo comment to enable this elsewhere, with link to bug

[vmpstr, 2017-02-15 20:50:09]

Description was changed from

==========
Enable check for auto raw pointer deduction on linux

This patch enables the auto raw pointer deduction check
on linux and fixes all of the places where the check is
currently triggered.

R=danakj@chromium.org
BUG=554600
==========

to

==========
Fix auto raw pointer deduction on linux

This patch fixes all of the places where the auto raw
pointer deduction is happening on linux

R=danakj@chromium.org
BUG=554600
==========

[danakj, 2017-02-15 20:53:09]

I suggest TBR brettw.

On Wed, Feb 15, 2017 at 3:47 PM, <vmpstr@chromium.org> wrote:

> On 2017/02/15 19:14:16, Nico wrote:
> > lgtm, but i'd recommend to land the build/ change separately, so that if
> turning
> > on the check needs to be reverted/relanded a few times, they don't
> revert all
> > the other stuff in this cl
>
> Do idea, I removed the build changes from this CL and will set the enable
> part
> separately.
>
> >
> >
> https://codereview.chromium.org/2691393002/diff/20001/
> build/config/clang/BUILD.gn
> > File build/config/clang/BUILD.gn (right):
> >
> >
> https://codereview.chromium.org/2691393002/diff/20001/
> build/config/clang/BUILD.gn#newcode40
> > build/config/clang/BUILD.gn:40: if (is_linux && !is_chromeos &&
> !is_chromecast)
> > {
> > add todo comment to enable this elsewhere, with link to bug
>
>
>
> https://codereview.chromium.org/2691393002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2017-02-15 22:46:10]

I spot-checked a few files. Assuming somebody has reviewed all files, this LGTM.

[danakj, 2017-02-15 23:09:57]

On Wed, Feb 15, 2017 at 5:46 PM, <brettw@chromium.org> wrote:

> I spot-checked a few files. Assuming somebody has reviewed all files, this
> LGTM.
>

I looked thru it all.


>
> https://codereview.chromium.org/2691393002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[vmpstr, 2017-02-15 23:12:59]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-02-15 23:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2691393002/#ps40001
(title: "nobuildchanges")

[commit-bot: I haz the power, 2017-02-15 23:14:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 23:26:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 23:26:52]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vmpstr, 2017-02-15 23:54:38]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-02-15 23:54:39]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
brettw@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2691393002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-15 23:55:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 00:04:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:04:57]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vmpstr, 2017-02-16 00:44:31]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-02-16 00:44:32]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
brettw@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2691393002/#ps70001
(title: "another rebase")

[commit-bot: I haz the power, 2017-02-16 00:45:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 02:12:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:12:39]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[vmpstr, 2017-02-16 17:50:57]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-16 17:51:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 18:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:03:32]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2017-02-16 18:20:10]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:20:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:34:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2017-02-16 19:42:14]

On 2017/02/16 19:34:59, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Just an update, the trybots seem to be a bit flaky. So far every failure was 1.
different 2. seemingly unrelated to this patch. I'll keep trying

[vmpstr, 2017-02-16 19:45:22]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:46:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:46:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:46:38]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[vmpstr, 2017-02-16 22:33:13]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-16 22:35:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 00:07:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:08:00]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[vmpstr, 2017-02-17 00:41:17]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:50:47]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[vmpstr, 2017-02-17 19:41:39]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:42:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:24:14]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[vmpstr, 2017-02-17 23:25:38]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:27:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:35:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:35:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[vmpstr, 2017-02-21 20:10:39]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:12:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 22:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:16:17]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[vmpstr, 2017-02-22 22:50:08]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-02-22 22:50:08]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
brettw@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2691393002/#ps90001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-22 22:51:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:43:31]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1487803808327130,
"parent_rev": "b83507471b95f9fd24b95e6cc720c6e44ce92f8f", "commit_rev":
"6d9996c865dc8d6901d0a004ff676d1215f4593c"}

[commit-bot: I haz the power, 2017-02-23 00:44:10]

Description was changed from

==========
Fix auto raw pointer deduction on linux

This patch fixes all of the places where the auto raw
pointer deduction is happening on linux

R=danakj@chromium.org
BUG=554600
==========

to

==========
Fix auto raw pointer deduction on linux

This patch fixes all of the places where the auto raw
pointer deduction is happening on linux

R=danakj@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2691393002
Cr-Commit-Position: refs/heads/master@{#452312}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d9996c865dc8d6901d0a004ff67...
==========

[commit-bot: I haz the power, 2017-02-23 00:44:14]

Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/6d9996c865dc8d6901d0a004ff67...