components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc - Issue 2691393002: Fix auto raw pointer deduction on linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/remote/remote_suggestion_unittest.cc ('k') | components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc

diff --git a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc

index deb218a3197f5f1238b96408cbdfc9d0eb35c2ff..d4ec38e483049b7edb8a35507ff5fd1a9ddb778f 100644

--- a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc

+++ b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc

@@ -539,8 +539,8 @@ SchedulingRemoteSuggestionsProvider::GetEnabledTriggerTypes() {

std::set<TriggerType> enabled_types;

for (const auto& token : tokens) {

- auto it = std::find(std::begin(kTriggerTypeNames),

- std::end(kTriggerTypeNames), token);

+ auto** it = std::find(std::begin(kTriggerTypeNames),

+ std::end(kTriggerTypeNames), token);

if (it == std::end(kTriggerTypeNames)) {

DLOG(WARNING) << "Failed to parse variation param "

<< kTriggerTypesParamName << " with string value "