components/password_manager/content/browser/credential_manager_impl.cc - Issue 2691393002: Fix auto raw pointer deduction on linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_impl.cc

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/history_quick_provider_performance_unittest.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_impl.cc

diff --git a/components/password_manager/content/browser/credential_manager_impl.cc b/components/password_manager/content/browser/credential_manager_impl.cc

index 7c01beaf2815e131f5d851aea2e365f3ea2222e0..fcd6940a168aeee27ab1721c875dce1923789d2c 100644

--- a/components/password_manager/content/browser/credential_manager_impl.cc

+++ b/components/password_manager/content/browser/credential_manager_impl.cc

@@ -104,8 +104,7 @@ void CredentialManagerImpl::OnProvisionalSaveComplete() {

// If this is a federated credential, check it against the federated matches

// produced by the PasswordFormManager. If a match is found, update it and

// return.

- for (const auto& match :

- form_manager_->form_fetcher()->GetFederatedMatches()) {

+ for (auto* match : form_manager_->form_fetcher()->GetFederatedMatches()) {

if (match->username_value == form.username_value &&

match->federation_origin.IsSameOriginWith(form.federation_origin)) {

form_manager_->Update(*match);