Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/jingle_session.cc ('k') | services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc
diff --git a/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc b/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc
index 00e9085d63955a982e969cc4960a7a56095b36fc..e6c64defadc465131bab2d62b6eef0ee53c47036 100644
--- a/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc
+++ b/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc
@@ -167,7 +167,7 @@ void SetSeccompCrashKey(const struct sandbox::arch_seccomp_data& args) {
size_t crash_key_length = nr.length() + arg1.length() + arg2.length() +
arg3.length() + arg4.length();
- for (const auto& prefix : prefixes) {
+ for (auto* prefix : prefixes) {
crash_key_length += strlen(prefix);
}
++crash_key_length; // For the trailing NUL byte.
@@ -178,7 +178,7 @@ void SetSeccompCrashKey(const struct sandbox::arch_seccomp_data& args) {
size_t offset = 0;
for (size_t i = 0; i < arraysize(values); ++i) {
const char* strings[2] = { prefixes[i], values[i] };
- for (const auto& string : strings) {
+ for (auto* string : strings) {
size_t string_len = strlen(string);
memmove(&crash_key[offset], string, string_len);
offset += string_len;
« no previous file with comments | « remoting/protocol/jingle_session.cc ('k') | services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698