Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: build/config/clang/BUILD.gn

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)
Patch Set: update Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/form_structure.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("clang.gni") 5 import("clang.gni")
6 import("//build/config/chromecast_build.gni") 6 import("//build/config/chromecast_build.gni")
7 7
8 config("find_bad_constructs") { 8 config("find_bad_constructs") {
9 if (clang_use_chrome_plugins) { 9 if (clang_use_chrome_plugins) {
10 cflags = [] 10 cflags = []
(...skipping 19 matching lines...) Expand all
30 ] 30 ]
31 } 31 }
32 32
33 cflags += [ 33 cflags += [
34 "-Xclang", 34 "-Xclang",
35 "-add-plugin", 35 "-add-plugin",
36 "-Xclang", 36 "-Xclang",
37 "find-bad-constructs", 37 "find-bad-constructs",
38 ] 38 ]
39 39
40 if (is_linux && !is_chromeos && !is_chromecast) {
Nico 2017/02/15 19:14:16 add todo comment to enable this elsewhere, with li
41 cflags += [
42 "-Xclang",
43 "-plugin-arg-find-bad-constructs",
44 "-Xclang",
45 "check-auto-raw-pointer",
46 ]
47 }
48
40 if ((is_linux || is_android) && !is_chromecast) { 49 if ((is_linux || is_android) && !is_chromecast) {
41 cflags += [ 50 cflags += [
42 "-Xclang", 51 "-Xclang",
43 "-plugin-arg-find-bad-constructs", 52 "-plugin-arg-find-bad-constructs",
44 "-Xclang", 53 "-Xclang",
45 "check-ipc", 54 "check-ipc",
46 ] 55 ]
47 } 56 }
48 } 57 }
49 } 58 }
50 59
51 # Enables some extra Clang-specific warnings. Some third-party code won't 60 # Enables some extra Clang-specific warnings. Some third-party code won't
52 # compile with these so may want to remove this config. 61 # compile with these so may want to remove this config.
53 config("extra_warnings") { 62 config("extra_warnings") {
54 cflags = [ 63 cflags = [
55 "-Wheader-hygiene", 64 "-Wheader-hygiene",
56 65
57 # Warns when a const char[] is converted to bool. 66 # Warns when a const char[] is converted to bool.
58 "-Wstring-conversion", 67 "-Wstring-conversion",
59 68
60 "-Wtautological-overlap-compare", 69 "-Wtautological-overlap-compare",
61 ] 70 ]
62 } 71 }
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/form_structure.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698